Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds an action to preview docs #886

Merged
merged 20 commits into from
Sep 27, 2024
Merged

adds an action to preview docs #886

merged 20 commits into from
Sep 27, 2024

Conversation

charlesfrye
Copy link
Collaborator

No description provided.

@charlesfrye
Copy link
Collaborator Author

charlesfrye commented Sep 26, 2024

The expected outcome of the checks on 90f43b7 is that the Preview Docs action will fail at the step where the docs are built.

This is a "positive control" -- testing that we catch a known issue.

EDIT: we failed somewhere else, due to divergence between the local GitHub Actions testing environment and the remote.

EDIT: in the checks on 0463de2, the workflow succeeded when it was expected to fail. That's because this workflow isn't run on 0463de2! Instead, it targets a merge commit associated with the PR, pull/886/merge, which has changes from main already merged. So the failure I was expecting did not occur. I have replicated the success of the workflow locally.

@charlesfrye
Copy link
Collaborator Author

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-d2a8a5c.modal.run

Copy link
Member

@ekzhang ekzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@charlesfrye charlesfrye changed the title [DRAFT] adding an action to build docs adds an action to preview docs Sep 27, 2024
@charlesfrye
Copy link
Collaborator Author

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-58233a7.modal.run

@charlesfrye charlesfrye merged commit 2197183 into main Sep 27, 2024
5 checks passed
@charlesfrye charlesfrye deleted the charlesfrye/build-docs branch September 27, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants